From 6db39ebfe2fde5e1733490ea0742cdc29485c969 Mon Sep 17 00:00:00 2001 From: Ryan Wilson-Perkin Date: Tue, 2 Apr 2024 15:08:32 -0400 Subject: [PATCH 1/2] Add React peer dependency for @shopify/polaris-icons This package depedends on React as a peer dependency in its produced output for SVG icons that end up rended as React components. --- .changeset/cold-buckets-count.md | 5 +++++ polaris-icons/package.json | 3 +++ 2 files changed, 8 insertions(+) create mode 100644 .changeset/cold-buckets-count.md diff --git a/.changeset/cold-buckets-count.md b/.changeset/cold-buckets-count.md new file mode 100644 index 00000000000..0d8f41f9b7c --- /dev/null +++ b/.changeset/cold-buckets-count.md @@ -0,0 +1,5 @@ +--- +'@shopify/polaris-icons': patch +--- + +Add missing peer dependency on React diff --git a/polaris-icons/package.json b/polaris-icons/package.json index ecf42882436..b700b68e0bc 100644 --- a/polaris-icons/package.json +++ b/polaris-icons/package.json @@ -63,5 +63,8 @@ "js-yaml": "^4.0.0", "rehype-parse": "^7.0.1", "unified": "^9.2.1" + }, + "peerDependencies": { + "react": "*" } } From 12bfe85a94ab9fd36aa0839f1b1e1eb0080ed578 Mon Sep 17 00:00:00 2001 From: Ryan Wilson-Perkin Date: Wed, 3 Apr 2024 09:36:06 -0400 Subject: [PATCH 2/2] Update polaris-icons/package.json Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com> --- polaris-icons/package.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/polaris-icons/package.json b/polaris-icons/package.json index b700b68e0bc..f9b17a6e1fa 100644 --- a/polaris-icons/package.json +++ b/polaris-icons/package.json @@ -66,5 +66,10 @@ }, "peerDependencies": { "react": "*" + }, + "peerDependenciesMeta": { + "react": { + "optional": true + } } }