diff --git a/UNRELEASED.md b/UNRELEASED.md index 9f8e83f2cce..bda8bc1ebe9 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -35,5 +35,6 @@ Upgraded Storybook to v5 ([#1140](https://github.com/Shopify/polaris-react/pull/ - Updated `ResourceList` to no longer use `componentWillReceiveProps`([#1235](https://github.com/Shopify/polaris-react/pull/1235)) - Updated `Tabs` to no longer use `componentWillReceiveProps`([#1221](https://github.com/Shopify/polaris-react/pull/1221)) - Removed an unneeded media query from Modal's `Header` component ([#1272](https://github.com/Shopify/polaris-react/pull/1272)) +- Replaces all instances where we pass a string representing a bundled icon into `Button`. Prefer passing in the React Component from `@shopify/polaris-icons` ([#1297](https://github.com/Shopify/polaris-react/pull/1297)) ### Deprecations diff --git a/src/components/Banner/Banner.tsx b/src/components/Banner/Banner.tsx index b71de7e0cf3..32bb2993448 100644 --- a/src/components/Banner/Banner.tsx +++ b/src/components/Banner/Banner.tsx @@ -1,6 +1,7 @@ import * as React from 'react'; import {classNames, variationName} from '@shopify/react-utilities/styles'; import { + CancelSmallMinor, CircleTickMajorTwotone, FlagMajorTwotone, CircleAlertMajorTwotone, @@ -147,7 +148,7 @@ export default class Banner extends React.PureComponent {