Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Applying font-family to button elements #1397
Due to the cascade order, the browser's User Agent Stylesheet, which defines a style for
WHY are these changes introduced?
WHAT is this pull request doing?
beefchimi left a comment •
Seems like a reasonable solution to me.
Do you know if there are other elements that would fall victim to this? Seems like form elements would be the most likely to be trifled with by the browser. Just curious if we need to include a few other elements, and perhaps a comment that signifies the important of applying
That being said - if any of that is true, your PR is a step in the right direction so I say ship it!
Just rebase off master, add an UNRELEASED entry describing the change, fixup the commit, and you should be good to go.