diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index ac9c293341c..f028083f12b 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -75,7 +75,7 @@ We’ll review your pull request and either merge it, request changes to it, or 1. If your pull request modifies any SVG files run `yarn optimize` 1. Format your code with `yarn format` 1. Make sure your code lints with `yarn lint` -1. Run the TypeScript compiler with `yarn ts` +1. Run the TypeScript compiler with `yarn type-check` 1. [Tophat 🎩](https://github.com/Shopify/polaris-react/blob/master/documentation/Tophatting.md) your changes locally with `yarn dev` 1. If you haven’t already, [sign a CLA](https://cla.shopify.com/) diff --git a/UNRELEASED.md b/UNRELEASED.md index dec4bb73622..fd34c8517f3 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -18,6 +18,8 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f ### Development workflow +- Renamed `yarn run ts` to `yarn run type-check` to match most other Shopify projects + ### Dependency upgrades ### Code quality diff --git a/dev.yml b/dev.yml index 60bae9b60b3..4101204621c 100644 --- a/dev.yml +++ b/dev.yml @@ -19,4 +19,4 @@ commands: server: yarn run dev style: yarn run lint test: yarn run test - type-check: yarn run ts + type-check: yarn run type-check diff --git a/package.json b/package.json index 5f6b704ab43..83d444eeb9b 100644 --- a/package.json +++ b/package.json @@ -32,12 +32,12 @@ "scripts": { "lint": "sewing-kit lint", "format": "sewing-kit format", - "ts": "tsc --noEmit", + "type-check": "sewing-kit type-check", "test": "sewing-kit test", "test:coverage": "yarn test --coverage", "test:ci": "yarn test --coverage", - "check": "npm-run-all lint ts test", - "check:ci": "npm-run-all lint ts test:ci", + "check": "npm-run-all lint type-check test", + "check:ci": "npm-run-all lint type-check test:ci", "clean": "rimraf build esnext styles types docs \"build-intermediate\" \"index.*\" \"./src/styles/polaris-tokens\" \"styles.{css,scss}\"", "clean:build": "rimraf \"build/!(cache|coverage|storybook)\" esnext styles types docs \"build-intermediate\" \"index.*\" \"./src/styles/polaris-tokens\" \"styles.{css,scss}\"", "optimize": "sewing-kit optimize",