Skip to content

Conversation

@tmlayton
Copy link
Contributor

WHY are these changes introduced?

Fixes #1988

WHAT is this pull request doing?

Allows number | string, updates the prop description

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React, {useState} from 'react';
import {Page, TextField} from '../src';

export default function Playground() {
  const [value, setValue] = useState('2008-07-22');

  return (
    <Page title="Playground">
      <TextField
        label="Any time this decade 🙄"
        value={value}
        onChange={setValue}
        type="date"
        min="2010-01-01"
        max="2019-12-31"
      />
    </Page>
  );
}

🎩 checklist

@tmlayton tmlayton requested review from BPScott and cboltt August 19, 2019 23:46
Copy link
Contributor

@cboltt cboltt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work for our use case! Cheers

@tmlayton tmlayton dismissed BPScott’s stale review August 21, 2019 19:58

Addressed suggestion

@tmlayton tmlayton merged commit 9c1ac84 into master Sep 5, 2019
@tmlayton tmlayton deleted the mix-max-date branch September 5, 2019 21:52
@chloerice chloerice temporarily deployed to production September 9, 2019 21:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TextField] Max and Min have the wrong type

4 participants