Update to latest Prettier and reformat #2070
Conversation
BPScott
force-pushed
the
prettier-bump
branch
from
fadd779 to
c7c1bf2
Compare
This version of prettier formats hooks a bit more cleanly which is handy as we're going to be using them a lot
BPScott
force-pushed
the
prettier-bump
branch
from
c7c1bf2 to
175eb71
Compare
src/components/Sheet/Sheet.tsx
Outdated
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| [], | ||
| ); | ||
| // eslint-disable react-hooks/exhaustive-deps |
There was a problem hiding this comment.
What's the issue here? can you disable prettier instead? I'd feel better disabling the styling tool than the linter
There was a problem hiding this comment.
We were originally disabling the react-hooks/exhaustive-deps rule because we were explictly saying the dependency array is empty, while linting things it should contain handleResize and prettier didn't like having that disable-next-line comment in the middle of the code.
It looks like vscode not spotting linting config updates means the handleResize had snuck back in when I wasn't looking. After a vscode restart it seems like we can keep to ignoring the exhaustive deps rule without using the block formatting - I've pushed a new commit to fix this up.
Not specifying this feels like a potential subtle bug but I'd like to keep this PR focused on formatting updates only
This version of prettier formats hooks a bit more cleanly which is handy as we're going to be using them a lot
2 participants
WHY are these changes introduced?
This version of prettier formats hooks a bit more cleanly which is handy
as we're going to be using them a lot
WHAT is this pull request doing?
Updates to latest prettier, and runs
yarn run formatover the content.One manual fix to Sheet.tsx had to be applied as prettier's formatting and ignoring the exhaustive-deps check didn't play nice.
Tophatting