[Modal] Removed inconsistent padding of modal section

[mitchmaps]

Why are these changes introduced?

Fixes #2061

What issue is this PR addressing?

The Modal component currently has an inconsistent top and bottom spacing in the section subcomponent.

What is this pull request doing?

This very simple change removes a repeated function call that made the top padding set to the base Polaris token value rather than the correct loose one. Now the top and bottom padding for the section is set to loose.

Before

After

[ghost]

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

[dleroux]

Thanks for doing this @mitchmaps ! Although I think the issue might have not been correct. The padding is correct on the .section, the issue is that there is no reason to have different rules for :first-of-type. Unless @AdamWhitcroft thinks it should be the be same all around (top right bottom left), we simply need to remove the :first-of-type.

[kaelig]

Can this also be fixed in polaris-rails, and perhaps Shopify/shopify for consistency?

[AdamWhitcroft]

Hey @dleroux, not super sure I follow what you mean, but from my POV the After screenshot from above here is what I'd like. The content in the modal sits within uniform padding from top/bottom/left/right of the section.

[dleroux]

Ok perfect. Just to clarify, the Sections are normally 16px top and bottom and 20px for the sides. For some unknown reason, the first section only has 20px at the top. This PR should have all sections including the first one to have 20px all around.

[dleroux]

🔥

[dleroux]

Thanks for doing this @mitchmaps! 🐑 🇮🇹 🎉

Following @kaelig comment is this something you could tackle in rails?

[mitchmaps]

No problem @dleroux ! And yes I'll hop into that on Monday!

[mitchmaps]

@dleroux looks like this change has already been implemented in polaris-rails upon inspection :)