Add displayName to WithAppProvider HoC #2093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
force-pushed
the
hoc-displayname
branch
from
186ffdb to
268a95c
Compare
This gives more meaningful feedback in tests and react devtools
BPScott
force-pushed
the
hoc-displayname
branch
from
268a95c to
bfba6cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Adding a displayname to HoCs based upon the wrapped component gives more meaningful feedback in react devtools. This follows react conventions https://reactjs.org/docs/higher-order-components.html#convention-wrap-the-display-name-for-easy-debugging
In devtools previously components like Page that use WithAppProvider looked like
WithProvider > Page.After this PR They look like
Page [WithAppProvider] > Page(where[Thing]is a little badge) which is a bit more meaningful.WHAT is this pull request doing?
Adds a displayName
How to 🎩
Inspect the defaut playground with react devtools and see a slightly nicer formatting for the Page component