[ResourceItem] Avoid using withAppProvider #2094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
force-pushed
the
resource-item-no-with-app-provider
branch
2 times, most recently
from
00ec635 to
4873360
Compare
perrupa
approved these changes
Sep 9, 2019
Contributor
perrupa
left a comment
perrupa
left a comment
There was a problem hiding this comment.
Looks great! Just had a quick Q about 3rd parties relying on the default export, but looks perfect otherwise!
Hookifying the whole class is going to be hard, but hookifying the wrapper component is pretty easy This should save 2 levels of nesting
BPScott
force-pushed
the
resource-item-no-with-app-provider
branch
from
4873360 to
26f4ca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Hookifying the whole class is going to be hard, but hookifying the
wrapper component is pretty easy
This should save 2 levels of nesting - the WithAppProvider, and the context consumer
WHAT is this pull request doing?
Remove withAppProvider and a context consumer from ResourceItem
How to 🎩
Check ResourceItem still renders correctly within a ResourceList