[ResourceItem] - Add default accessibility label and remove a11y_shitlist

[dleroux]

WHY are these changes introduced?

Currently, when an accessibilityLabel is not provided to the Resource List the overlaying Anchor has no content which doesn't meet our accessibility requirement

"Anchor element found with a valid href attribute, but no link content has been supplied."

WHAT is this pull request doing?

Provides a value but either outputting the specified accessibilityLabel if none a is provided text that will include the name prop, or the resourceName, whichever is provided. For example

View details for Mae Jemison OR View details for customer

This change will also allow us to remove the a11y_shitlist 🎉

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:

import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility
• Updated the component's README.md with documentation changes
• Tophatted documentation changes in the style guide
• For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

[dleroux]

@amrocha with this change we can remove all the a11y_shitlist! The tests were all based on the shitlist. Any suggestion on testing the actual script or do you feel we are good without it?

Codecov here is not showing anything useful that I can see.

[amrocha]

I love it, thank you so much for taking this on!

[amrocha]

@dleroux I think we're fine to delete the tests, the script is simple enough that I'm happy with it as is

[amrocha]

@dpersing Hey Devon check this out

[BPScott]

Aww yes, this is a fantastic milestone for accessibility stuff!