Hookify AccountConnect, ActionList and AppProvider examples #2126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
reviewed
Sep 12, 2019
Member
BPScott
left a comment
BPScott
left a comment
There was a problem hiding this comment.
All looking pretty good.
One suggestion regarding an optimization of toggles, which I get the feeling will crop up a lot.
6 tasks
AndrewMusgrave
force-pushed
the
hookify-examples-1
branch
from
042a9d9 to
8a124c3
Compare
BPScott
approved these changes
Sep 24, 2019
AndrewMusgrave
force-pushed
the
hookify-examples-1
branch
from
8a124c3 to
8c74329
Compare
AndrewMusgrave
force-pushed
the
hookify-examples-1
branch
from
8c74329 to
58889d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Convert examples to hooks
WHAT is this pull request doing?
Converting AccountConnect, ActionList and AppProvider class-based examples to hooks
STILL TO DO
I'm making quite a few pr's converting examples to hooks so I anticipate lots of
unreleased.mdconflicts, so I'll add the entry before I merge.How to 🎩
Make sure the behavior of the example mirrors the style guide
🎩 checklist
README.mdwith documentation changes