Skip to content

Conversation

@amrocha
Copy link
Contributor

@amrocha amrocha commented Sep 27, 2019

WHY are these changes introduced?

We don't have much observability into what the effect of our changes is, and sometimes that can cause unexpected bugs. This tries to address that.

WHAT is this pull request doing?

Adds a github action that runs yarn splash and comments on PRs with their splash zone

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2019

No changes

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

No significant changes to src/**/*.tsx were detected.


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@amrocha amrocha force-pushed the test-splash-action branch 3 times, most recently from 58d27b7 to 2b4f053 Compare September 30, 2019 22:18
@amrocha amrocha changed the title Test splash action Add discoverability-action Sep 30, 2019
@amrocha amrocha merged commit 5fff6c6 into master Sep 30, 2019
@amrocha amrocha deleted the test-splash-action branch September 30, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants