[Portal][ThemeProvider][Color System] move portal node within theme provider node to enable theming #2224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrosenthal
force-pushed
the
portal-within-theme-provider-node
branch
from
a533026 to
b10fda1
Compare
Contributor
danrosenthal
force-pushed
the
portal-within-theme-provider-node
branch
from
b10fda1 to
5c1124f
Compare
danrosenthal
force-pushed
the
portal-within-theme-provider-node
branch
2 times, most recently
from
abf05db to
4d076ca
Compare
Co-authored-by: Tim Layton <tim.layton@shopify.com>
danrosenthal
force-pushed
the
portal-within-theme-provider-node
branch
from
4d076ca to
d62cff6
Compare
Author
Co-Authored-By: Tim Layton <tmlayton@users.noreply.github.com>
Author
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Tim Layton tim.layton@shopify.com
WHY are these changes introduced?
Currently (in
master) thePortalcomponent renders portals directly within thebodyelement. This places any components rendered in aPortal(Modal,Sheet) outside the scope of theThemeProvidernode. The theme provider component sets its custom properties on a node, so in order to make the modal and sheet components theme-able with the the theme provider component, they need to be rendered within the theme provider component's node.WHAT is this pull request doing?
This pull request adds a way to hook into the theme provider component's node, and moves the portal component's node within that node.
How to 🎩
Use the chromaui build to tophat
z-indexand anything else you can think of on the examples forFrame,Modal,Sheet, andFilters.