Remove unused items from withAppProvider #2277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
force-pushed
the
simpler-with-app-provider
branch
2 times, most recently
from
e622267 to
cf6b9d9
Compare
link, theme and scrollLockManager are no longer used, so remove them
BPScott
force-pushed
the
simpler-with-app-provider
branch
from
cf6b9d9 to
5c290a7
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Simplifying withAppProvider, stopping it doing work that is no longer required
WHAT is this pull request doing?
Removes
link,themeandscrollLockManagerfrom the object returned by withAppProvider as nothing consumes them any moreHow to 🎩
check tests and type check pass.