From 4da3e85d81165d83e15081152b5b20a2aa6bcf4a Mon Sep 17 00:00:00 2001 From: Daniel Leroux Date: Fri, 8 Nov 2019 13:12:51 -0500 Subject: [PATCH 1/2] adding height to topbar --- UNRELEASED.md | 2 ++ src/components/Frame/Frame.scss | 1 + 2 files changed, 3 insertions(+) diff --git a/UNRELEASED.md b/UNRELEASED.md index 017db5e272f..936694ab0d6 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -17,6 +17,8 @@ - Changed Button's `disclosure` prop to be `boolean | "up" | "down"`, allowing greater control over the direction the disclosure caret faces ([#2431](https://github.com/Shopify/polaris-react/pull/2431)) - Fixed an issue where the dropzone component jumped from an extra-large layout to a layout based on the width of it's container ([#2412](https://github.com/Shopify/polaris-react/pull/2412)) - Fixed a race condition in DatePicker ([#2373](https://github.com/Shopify/polaris-react/pull/2373)) +- Fixed an issue where types were not generated for a JSON config file ([#2361](https://github.com/Shopify/polaris-react/pull/2361)) +- Added the top bar height to the `Topbar` in `Frame` to ensure the `Sticky` components get the correct top position ([2415](https://github.com/Shopify/polaris-react/pull/2415)) ### Documentation diff --git a/src/components/Frame/Frame.scss b/src/components/Frame/Frame.scss index 3ef14946c22..403a993b9e8 100644 --- a/src/components/Frame/Frame.scss +++ b/src/components/Frame/Frame.scss @@ -104,6 +104,7 @@ $skip-vertical-offset: rem(10px); top: 0; left: 0; width: 100%; + height: top-bar-height(); } .ContextualSaveBar { From f161e00991dd528756c8c5d52ff9a2516334e7c6 Mon Sep 17 00:00:00 2001 From: Daniel Leroux Date: Thu, 21 Nov 2019 09:43:00 -0500 Subject: [PATCH 2/2] Update UNRELEASED.md Co-Authored-By: Andrew Musgrave --- UNRELEASED.md | 1 - 1 file changed, 1 deletion(-) diff --git a/UNRELEASED.md b/UNRELEASED.md index 936694ab0d6..e6240faf1ee 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -17,7 +17,6 @@ - Changed Button's `disclosure` prop to be `boolean | "up" | "down"`, allowing greater control over the direction the disclosure caret faces ([#2431](https://github.com/Shopify/polaris-react/pull/2431)) - Fixed an issue where the dropzone component jumped from an extra-large layout to a layout based on the width of it's container ([#2412](https://github.com/Shopify/polaris-react/pull/2412)) - Fixed a race condition in DatePicker ([#2373](https://github.com/Shopify/polaris-react/pull/2373)) -- Fixed an issue where types were not generated for a JSON config file ([#2361](https://github.com/Shopify/polaris-react/pull/2361)) - Added the top bar height to the `Topbar` in `Frame` to ensure the `Sticky` components get the correct top position ([2415](https://github.com/Shopify/polaris-react/pull/2415)) ### Documentation