Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unstable telemetry feature added for icons #2561

Merged
merged 1 commit into from Jan 15, 2020
Merged

Remove unstable telemetry feature added for icons #2561

merged 1 commit into from Jan 15, 2020

Conversation

amrocha
Copy link
Contributor

@amrocha amrocha commented Dec 17, 2019

WHY are these changes introduced?

We introduced these changes to gather some data in web about icons usage. We have finished gathering data, so there's no need to keep this code around any longer

WHAT is this pull request doing?

Reverts #2368

How to 馃帺

馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines

Copy-paste this code in playground/Playground.tsx: 
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

馃帺 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @鈥奌YPD, @鈥妋irualves, @鈥妔arahill, or @鈥妑y5n to update the Polaris UI kit

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2019 •
edited

馃挦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

Files modified6
Files potentially affected83

Details

All files potentially affected (total: 83)
馃搫 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

馃З src/components/AppProvider/AppProvider.tsx (total: 0)

Files potentially affected (total: 0)

馃З src/components/Icon/Icon.tsx (total: 83)

Files potentially affected (total: 83)

馃З src/utilities/telemetry/context.tsx (total: 0)

Files potentially affected (total: 0)

馃З src/utilities/telemetry/hooks.tsx (total: 0)

Files potentially affected (total: 0)

馃З src/utilities/telemetry/index.ts (total: 0)

Files potentially affected (total: 0)

This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@amrocha amrocha requested a review from BPScott December 17, 2019 19:31
BPScott
BPScott approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On errant space but whatevs.

Not tophatted but LGTM. IIRC we're going to wait till after christmas and https://github.com/Shopify/web/pull/21923 is merged before we merge this

src/components/SkeletonPage/SkeletonPage.tsx Outdated Show resolved Hide resolved
@amrocha
Copy link
Contributor Author

amrocha commented Dec 17, 2019

The web PR needs to be merged first (https://github.com/Shopify/web/pull/21923)

Then we can merge the core and polaris PRs whenever

@amrocha amrocha merged commit 8047d70 into master Jan 15, 2020
@amrocha amrocha deleted the revert-icon-analytics branch January 15, 2020 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BPScott BPScott BPScott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrocha @BPScott