[Tag] Adds type=button attribute to Clickable Tag

[awebartisan]

Adds type=button attribute to Clickable Tag.

WHY are these changes introduced?

Fixes #2894

WHAT is this pull request doing?

Adding type="button" attribute to clickable Tag.

[ghost]

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

[chloerice]

Thanks for catching this, @awebartisan!!

[chloerice]

Just need you to sign the CLA and move the attributes on the button element to their own lines to fix the lint error causing the build to fail. If you happen to use VSCode as your text editor, add the Prettier extension and make any edit to the file then save and Prettier will autofix for you.

[awebartisan]

Hi @chloerice, I made the commit before signing the CLA. Is there any way I can re-run the CLA check?

Thanks.

[chloerice]

Hi @chloerice, I made the commit before signing the CLA. Is there any way I can re-run the CLA check?

Thanks.

Hey @awebartisan! You'll need to add an entry to UNRELEASED.md under Bug fixes to pass the change log check.

- Fixed `Tag` submitting forms when `onClick` is set ([#2895](https://github.com/Shopify/polaris-react/pull/2895))

The linter is also complaining about extra whitespace after <button => <button.

Pull down the commit made through the PR suggestion, fix that extra whitespace, and add the change log entry, all the checks will run again after you push your changes up.

Requested changes made ✅

[chloerice]

Thank you so much for contributing @awebartisan 🙏!!

[chloerice]

Hey @awebartisan, everything is good to go but a few of the PR checks froze up. Would you mind pushing up from your branch again to re-trigger the checks?

[awebartisan]

Hey @chloerice , I would need to make some changes in order to be able to commit/push again. Can you suggest some?

Thanks 🙏🏼

[chloerice]

Hey @chloerice , I would need to make some changes in order to be able to commit/push again. Can you suggest some?

Thanks 🙏🏼

Hey @awebartisan, my teammate informed me that those unrun checks don't run on public contributions, so all I need to do is resolve the conflicts in UNRELEASED.md and I'll be able to merge for you 😊

[awebartisan]

Thank you 🙏🏼 I thought I messed up badly 😞Thank you for bearing with me.

Looking forward to merge of my first pull request in Shopify ecosystem 😍

[ghost]

🎉 Thanks for your contribution to Polaris React!

[juanpprieto]

Unfortunately this change makes the type prop to be hardcoded as "button". Frameworks such as https://github.com/remix-run/remix use native form submit flows in creative ways to communicate between the client and the server in a full React context. Please allow the type prop to be overwritten when passed in.

Thanks!
JP