New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Page] Adding additionalNavigation prop #2942
Conversation
馃煝 This pull request modifies 5 files and might impact 2 other files. Details:All files potentially affected (total: 2)馃搫
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and tab order look good. I'm wondering in the future if we can be a little bit more clever about the positioning of the rollup activator so it's not positioned absolutely and can wrap if need be.
As Alex mentioned in slack this does look a little bit tight. If you could add spacing consistent with mobile it would be perfect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Noticed a minor spacing issue on desktop while tophatting. @kyledurand has more detail above!
Yeah, that's not a bad idea. I'm not sure if wrapping is best there or what, but would be nice to handle it better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clear separation now 馃憤
WHY are these changes introduced?
For a project I am working on currently, we need to make better use of the space between the breadcrumbs and pagination/actions menu. Currently we have some hacks with absolute positioning, but I would rather this be a part of the page component so we can make it more reliable and also re-arrange if needed (probably in the new design language too). My current implementation gets the wrong tab order as well because I need to place the elements inside the page content instead of in the proper place in the header.
WHAT is this pull request doing?
This adds a new
additionalNavigation
prop to<Page>
that accepts a React Node and renders it in the correct space.This is what it looks like with an avatar in that spot:
How to 馃帺
I added an example to our
Page with all header elements
example in the README馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines
馃帺 checklist
README.md
with documentation changes