Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag background #3300

Merged
merged 1 commit into from Sep 24, 2020
Merged

Update tag background #3300

merged 1 commit into from Sep 24, 2020

Conversation

alex-page
Copy link
Member

@alex-page alex-page commented Sep 23, 2020

View the changes

WHY are these changes introduced?

Fixes #3289

Screen Shot 2020-09-23 at 11 22 32 AM

WHAT is this pull request doing?

Screen Shot 2020-09-23 at 11 22 15 AM

How to 馃帺

The tabs are now the same color as the background, however they should not be used on that color. This makes tophatting a bit weird.

馃帺 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @鈥奌YPD, @鈥妋irualves, @鈥妔arahill, or @鈥妑y5n to update the Polaris UI kit

@github-actions
Copy link
Contributor

馃煛 This pull request modifies 1 files and might impact 4 other files. This is an average splash zone for a change, remember to tophat areas that could be affected.

Details:
All files potentially affected (total: 4)
馃帹 src/components/Tag/Tag.scss (total: 4)

Files potentially affected (total: 4)

@alex-page alex-page added the 馃Skip Changelog Causes CI to ignore changelog update check. label Sep 23, 2020
@alex-page alex-page self-assigned this Sep 23, 2020
@alex-page alex-page merged commit a63fab7 into master Sep 24, 2020
@alex-page alex-page deleted the tabs-bg branch September 24, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs background color should be grey
2 participants