Skip to content

Conversation

@YannCedric
Copy link
Contributor

WHY are these changes introduced?

Fixes #3541

WHAT is this pull request doing?

Change content prop's type to not only accept string, but any React.Node.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@ghost
Copy link

ghost commented Oct 23, 2020

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2020

🟢 This pull request modifies 2 files and might impact 3 other files.

Details:
All files potentially affected (total: 3)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🧩 src/components/Tooltip/Tooltip.tsx (total: 3)

Files potentially affected (total: 3)

@YannCedric YannCedric requested a review from BPScott October 23, 2020 19:23
Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Merge whenever you're ready.

@YannCedric YannCedric force-pushed the generalize-tooltip-content branch from fecb8e6 to f9d6cdc Compare October 26, 2020 15:00
@YannCedric YannCedric merged commit 523e084 into master Oct 26, 2020
@YannCedric YannCedric deleted the generalize-tooltip-content branch October 26, 2020 16:10
@ghost
Copy link

ghost commented Oct 26, 2020

🎉 Thanks for your contribution to Polaris React!

sylvhama pushed a commit that referenced this pull request Mar 26, 2021
* Change content type to allow React.Node

* Update unreleased changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tooltip only accepts string contents

2 participants