Skip to content

Conversation

@lordofthecactus
Copy link
Contributor

WHY are these changes introduced?

Found in Tags.scss a media query for ms-high-contrast without a selector. This is invalid css which prevents dart-sass compilation and possibly generate other issues.

WHAT is this pull request doing?

Put the media query back to the Tags class selector as it was before #2774 which introduced the bug.

Before with ms-high-contrast active

After with ms-high-contrast active

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';

import {Page, Tag} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      <Tag>Polaris</Tag>
    </Page>
  );
}

🎩 checklist

@ghost
Copy link

ghost commented Jan 11, 2021

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@lordofthecactus lordofthecactus self-assigned this Jan 11, 2021
@lordofthecactus lordofthecactus added Accessibility Needs design, development, or content work relating to accessibility. Bug Something is broken and not working as intended in the system. labels Jan 11, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2021

🟡 This pull request modifies 2 files and might impact 4 other files. This is an average splash zone for a change, remember to tophat areas that could be affected.

Details:
All files potentially affected (total: 4)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/Tag/Tag.scss (total: 4)

Files potentially affected (total: 4)

Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Update the PR based on Kaelig's suggestion and merge when you're ready!

Co-authored-by: Kaelig Deloumeau-Prigent <kaelig@users.noreply.github.com>
@alex-page alex-page merged commit 99194d2 into master Jan 12, 2021
@alex-page alex-page deleted the a11y-tags-high-contrast-fix branch January 12, 2021 02:32
@ghost
Copy link

ghost commented Jan 12, 2021

🎉 Thanks for your contribution to Polaris React!

sylvhama pushed a commit that referenced this pull request Mar 26, 2021
…in Tags (#3810)

Co-authored-by: Kaelig Deloumeau-Prigent <kaelig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessibility Needs design, development, or content work relating to accessibility. Bug Something is broken and not working as intended in the system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants