-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Tags] Fix invalid ms-high-contrast media query css without selector in Tags #3810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
|
🟡 This pull request modifies 2 files and might impact 4 other files. This is an average splash zone for a change, remember to tophat areas that could be affected. Details:All files potentially affected (total: 4)📄
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Update the PR based on Kaelig's suggestion and merge when you're ready!
Co-authored-by: Kaelig Deloumeau-Prigent <kaelig@users.noreply.github.com>
|
🎉 Thanks for your contribution to Polaris React! |
…in Tags (#3810) Co-authored-by: Kaelig Deloumeau-Prigent <kaelig@users.noreply.github.com>
WHY are these changes introduced?
Found in
Tags.scssa media query forms-high-contrastwithout a selector. This is invalid css which preventsdart-sasscompilation and possibly generate other issues.WHAT is this pull request doing?
Put the media query back to the
Tagsclass selector as it was before #2774 which introduced the bug.Before with

ms-high-contrastactiveAfter with

ms-high-contrastactiveHow to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist