From 21c875f4d6153d6282077b79a859c1743aa31e93 Mon Sep 17 00:00:00 2001 From: Dominic McPhee Date: Tue, 16 Nov 2021 14:07:02 -0500 Subject: [PATCH 1/3] [Popover] Use duration fast for exit --- .../Popover/components/PopoverOverlay/PopoverOverlay.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/Popover/components/PopoverOverlay/PopoverOverlay.tsx b/src/components/Popover/components/PopoverOverlay/PopoverOverlay.tsx index f318c56ddb3..9e302923977 100644 --- a/src/components/Popover/components/PopoverOverlay/PopoverOverlay.tsx +++ b/src/components/Popover/components/PopoverOverlay/PopoverOverlay.tsx @@ -1,5 +1,5 @@ import React, {PureComponent, Children, createRef} from 'react'; -import {durationFast, durationBase} from '@shopify/polaris-tokens'; +import {durationFast} from '@shopify/polaris-tokens'; import {findFirstFocusableNode} from '../../../../utilities/focus'; import {ThemeProvider, ThemeProviderProps} from '../../../ThemeProvider'; @@ -111,7 +111,7 @@ export class PopoverOverlay extends PureComponent { this.clearTransitionTimeout(); this.exitingTimer = window.setTimeout(() => { this.setState({transitionStatus: TransitionStatus.Exited}); - }, durationBase); + }, durationFast); }); } } From d183b17ce6c4cbc47f8dedfea2897c1d27ac9fc2 Mon Sep 17 00:00:00 2001 From: Dominic McPhee Date: Tue, 16 Nov 2021 14:47:55 -0500 Subject: [PATCH 2/3] Add to UNRELEASED --- UNRELEASED.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UNRELEASED.md b/UNRELEASED.md index e8e82312ebf..b1b2decdae1 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -8,6 +8,8 @@ Use [the changelog guidelines](/documentation/Versioning%20and%20changelog.md) t - Updated `VisuallyHidden` styles to not use `top` or `clip` ([#4641](https://github.com/Shopify/polaris-react/pull/4641)) - Added `PlainAction` type to `ComplexAction`. ([#4489](https://github.com/Shopify/polaris-react/pull/4489)) +- Added `PlainAction` type to `ComplexAction`. ([#4489](https://github.com/Shopify/polaris-react/pull/4489) +- Updated timeout of `Popover` exit to `durationFast`. ([#4651](https://github.com/Shopify/polaris-react/pull/4651)) ### Bug fixes From d269525b94c4cabceede6f26aa4b2d11c6898531 Mon Sep 17 00:00:00 2001 From: Dominic McPhee Date: Tue, 16 Nov 2021 14:53:10 -0500 Subject: [PATCH 3/3] Removing extra line from unreleased --- UNRELEASED.md | 1 - 1 file changed, 1 deletion(-) diff --git a/UNRELEASED.md b/UNRELEASED.md index b1b2decdae1..e2181faed53 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -8,7 +8,6 @@ Use [the changelog guidelines](/documentation/Versioning%20and%20changelog.md) t - Updated `VisuallyHidden` styles to not use `top` or `clip` ([#4641](https://github.com/Shopify/polaris-react/pull/4641)) - Added `PlainAction` type to `ComplexAction`. ([#4489](https://github.com/Shopify/polaris-react/pull/4489)) -- Added `PlainAction` type to `ComplexAction`. ([#4489](https://github.com/Shopify/polaris-react/pull/4489) - Updated timeout of `Popover` exit to `durationFast`. ([#4651](https://github.com/Shopify/polaris-react/pull/4651)) ### Bug fixes