From 3ba648a592f9f74febeb7e68303130267d169357 Mon Sep 17 00:00:00 2001 From: Lo Kim Date: Thu, 27 Jan 2022 15:08:00 -0500 Subject: [PATCH 1/2] [DataTable] Fix table row border bottom The color was darker and inconsistent with the way other table headers are displayed. --- src/components/DataTable/DataTable.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/DataTable/DataTable.scss b/src/components/DataTable/DataTable.scss index 2a05ee5be0f..fc68bb5c607 100644 --- a/src/components/DataTable/DataTable.scss +++ b/src/components/DataTable/DataTable.scss @@ -92,7 +92,7 @@ $breakpoint: 768px; .Cell-header { @include text-emphasis-normal; - border-bottom: border(dark); + border-bottom: border('divider'); border-top: 0; } @@ -165,7 +165,7 @@ $breakpoint: 768px; .Cell-total { @include text-emphasis-strong; background: var(--p-surface-subdued); - border-bottom: border(); + border-bottom: border('divider'); } .Cell-total-footer { From 218c401cca640548ed08ff515ddbc4e71c75337d Mon Sep 17 00:00:00 2001 From: Lo Kim Date: Thu, 27 Jan 2022 15:12:46 -0500 Subject: [PATCH 2/2] Update UNRELEASED.md --- UNRELEASED.md | 1 + 1 file changed, 1 insertion(+) diff --git a/UNRELEASED.md b/UNRELEASED.md index 02a75096a02..c0a87c6d6f6 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -18,6 +18,7 @@ Use [the changelog guidelines](/documentation/Versioning%20and%20changelog.md) t - Fixed `segmented` `ButtonGroup` misaligning icon only buttons when grouped with text only buttons ([#4079](https://github.com/Shopify/polaris-react/issues/4079)) - Added missing styles for `destructive` `Page` `secondaryActions` ([#4647](https://github.com/Shopify/polaris-react/pull/4647)) - Removed `min-height` from `Page` `additionalNavigation` ([#4952](https://github.com/Shopify/polaris-react/pull/4952)) +- Fixed overly dark `bottom-border` on `DataTable` header cell and total cell. ([#4975])(https://github.com/Shopify/polaris-react/pull/4975) ### Documentation