From 9653a8e5263aaede3bc5bccfecec61e363edd3c7 Mon Sep 17 00:00:00 2001 From: aveline Date: Mon, 7 Feb 2022 15:12:57 -0800 Subject: [PATCH 1/6] Update migrating-from-v8-to-v9.md --- documentation/guides/migrating-from-v8-to-v9.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/documentation/guides/migrating-from-v8-to-v9.md b/documentation/guides/migrating-from-v8-to-v9.md index 32ea7d24904..f38fa4b3a13 100644 --- a/documentation/guides/migrating-from-v8-to-v9.md +++ b/documentation/guides/migrating-from-v8-to-v9.md @@ -190,6 +190,10 @@ We replaced a few of the following filter function instances with color tokens i | `ms-high-contrast-color('button-text-background')` | `buttonFace` | | `ms-high-contrast-color('background')` | `window` | +#### `px()` + +All `px` values are now automatically converted to `rem` through our postcss config with the `postcss-pxtorem` plugin. + #### `shadow()` | Function | Replacement Value/Token | From 19c3653977e88ee9731e62ddff7d4d9fd87bcb19 Mon Sep 17 00:00:00 2001 From: aveline Date: Mon, 7 Feb 2022 16:20:24 -0800 Subject: [PATCH 2/6] Update migrating-from-v8-to-v9.md --- documentation/guides/migrating-from-v8-to-v9.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/documentation/guides/migrating-from-v8-to-v9.md b/documentation/guides/migrating-from-v8-to-v9.md index f38fa4b3a13..c7e3cdd03b3 100644 --- a/documentation/guides/migrating-from-v8-to-v9.md +++ b/documentation/guides/migrating-from-v8-to-v9.md @@ -192,7 +192,9 @@ We replaced a few of the following filter function instances with color tokens i #### `px()` -All `px` values are now automatically converted to `rem` through our postcss config with the `postcss-pxtorem` plugin. +| Function | Source to copy | +| -------- | -------------------- | +| `px()` | [link to function]() | #### `shadow()` From 89efa97eb53e22ff076cc8f2d4059e5fea784cf5 Mon Sep 17 00:00:00 2001 From: aveline Date: Wed, 9 Feb 2022 13:15:39 -0800 Subject: [PATCH 3/6] Populate link to px() definition --- documentation/guides/migrating-from-v8-to-v9.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/documentation/guides/migrating-from-v8-to-v9.md b/documentation/guides/migrating-from-v8-to-v9.md index d8ef80cbbe3..2ca24a2e3e2 100644 --- a/documentation/guides/migrating-from-v8-to-v9.md +++ b/documentation/guides/migrating-from-v8-to-v9.md @@ -231,9 +231,10 @@ We replaced a few of the following filter function instances with color tokens i #### `px()` -| Function | Source to copy | -| -------- | -------------------- | -| `px()` | [link to function]() | +This function has been deprecated, but the definition can be copied and used locally. +| Function | Source | +| -------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------- | +| `px()` | [definition](https://github.com/Shopify/polaris-react/blob/a75c305d2cc4b72808d6d9f7302d479c68178706/documentation/guides/legacy-polaris-v8-public-api.scss#L317) | #### `shadow()` From 8be509bf975cb9d794650d965110f060c72ab53f Mon Sep 17 00:00:00 2001 From: aveline Date: Wed, 9 Feb 2022 13:28:29 -0800 Subject: [PATCH 4/6] Add migration guidance for px() --- documentation/guides/migrating-from-v8-to-v9.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/documentation/guides/migrating-from-v8-to-v9.md b/documentation/guides/migrating-from-v8-to-v9.md index 2ca24a2e3e2..b87c8831ca8 100644 --- a/documentation/guides/migrating-from-v8-to-v9.md +++ b/documentation/guides/migrating-from-v8-to-v9.md @@ -232,9 +232,10 @@ We replaced a few of the following filter function instances with color tokens i #### `px()` This function has been deprecated, but the definition can be copied and used locally. -| Function | Source | -| -------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| `px()` | [definition](https://github.com/Shopify/polaris-react/blob/a75c305d2cc4b72808d6d9f7302d479c68178706/documentation/guides/legacy-polaris-v8-public-api.scss#L317) | + +| Function | Source | +| -------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------- | +| `px()` | [definition](https://github.com/Shopify/polaris-react/blob/b443d114d447df15d9e72914c8ca5058439a175e/documentation/guides/legacy-polaris-v8-public-api.scss#L313) | #### `shadow()` From d039f3a6c0b50dcca440dc5acfdfda377577e81f Mon Sep 17 00:00:00 2001 From: aveline Date: Wed, 9 Feb 2022 15:19:59 -0800 Subject: [PATCH 5/6] Update permalinks to highlight range --- documentation/guides/migrating-from-v8-to-v9.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/documentation/guides/migrating-from-v8-to-v9.md b/documentation/guides/migrating-from-v8-to-v9.md index 6436e33cf86..a07a8dd1cf4 100644 --- a/documentation/guides/migrating-from-v8-to-v9.md +++ b/documentation/guides/migrating-from-v8-to-v9.md @@ -273,15 +273,15 @@ For `` instances that are hard coded values, see if you can replac This function has been deprecated, but the definition can be copied and used locally. | Function | Source | | -------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| `px()` | [definition](https://github.com/Shopify/polaris-react/blob/b443d114d447df15d9e72914c8ca5058439a175e/documentation/guides/legacy-polaris-v8-public-api.scss#L313) | +| `px()` | [definition](https://github.com/Shopify/polaris-react/blob/b443d114d447df15d9e72914c8ca5058439a175e/documentation/guides/legacy-polaris-v8-public-api.scss##L313-L331) | #### `rem()` This function has been deprecated, but the definition can be copied and used locally. -| Function | Source | -| -------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| `rem()` | [definition](https://github.com/Shopify/polaris-react/blob/b443d114d447df15d9e72914c8ca5058439a175e/documentation/guides/legacy-polaris-v8-public-api.scss#L293) | +| Function | Source | +| -------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------- | +| `rem()` | [definition](https://github.com/Shopify/polaris-react/blob/b443d114d447df15d9e72914c8ca5058439a175e/documentation/guides/legacy-polaris-v8-public-api.scss#L293-L311) | #### `shadow()` From 9414549796540212634492cd5347a250379fff52 Mon Sep 17 00:00:00 2001 From: aveline Date: Wed, 9 Feb 2022 15:21:35 -0800 Subject: [PATCH 6/6] Update permalink to highlight range --- documentation/guides/migrating-from-v8-to-v9.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/documentation/guides/migrating-from-v8-to-v9.md b/documentation/guides/migrating-from-v8-to-v9.md index b948e53823f..b0e40056bb7 100644 --- a/documentation/guides/migrating-from-v8-to-v9.md +++ b/documentation/guides/migrating-from-v8-to-v9.md @@ -154,7 +154,7 @@ A list of functions/mixins and their value equivalents or new token values. This function has been deprecated, but the definition can be copied and used locally. | Function | Source | | -------- | -------------------- | -| `em()` | [definition](https://github.com/Shopify/polaris-react/blob/b443d114d447df15d9e72914c8ca5058439a175e/documentation/guides/legacy-polaris-v8-public-api.scss#L333) | +| `em()` | [definition](https://github.com/Shopify/polaris-react/blob/b443d114d447df15d9e72914c8ca5058439a175e/documentation/guides/legacy-polaris-v8-public-api.scss#L333-L352) | #### `easing()`