From f18523dd4028ac3c56ce035efcd7ec2c686e2bcf Mon Sep 17 00:00:00 2001 From: Romello Goodman Date: Thu, 10 Feb 2022 12:06:28 -0500 Subject: [PATCH 1/3] Adding migration documentation for the skeletonpage component --- documentation/guides/migrating-from-v8-to-v9.md | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/documentation/guides/migrating-from-v8-to-v9.md b/documentation/guides/migrating-from-v8-to-v9.md index 788f27c1b86..202b3fe1782 100644 --- a/documentation/guides/migrating-from-v8-to-v9.md +++ b/documentation/guides/migrating-from-v8-to-v9.md @@ -2,7 +2,9 @@ Polaris v9.0.0 ([full release notes](https://github.com/Shopify/polaris-react/releases/tag/v9.0.0)) features removal of the public scss api and removal of scss functions and mixins. -## From `ThemeProvider` to `CustomProperties` +## Components + +### From `ThemeProvider` to `CustomProperties` The `ThemeProvider` has been deprecated in favor of the new `CustomProperties` component. As a result, a number of internal components using the `ThemeProvider` have been updated to use `CustomProperties` and adjusted their prop interfaces accordingly (such as: `AppProvider`, `Popover`, etc.). @@ -28,7 +30,7 @@ The `CustomProperties` component will generate Polaris custom properties (`--p-* > IMPORTANT: We do not officially support dark mode at this time and the example above is simply representative of the current implementation. -## `AppProvider` changes +### `AppProvider` changes The `ThemeProvider` has been removed from the `AppProvider` and replaced with the `CustomProperties` component. Thus, the `AppProvider` no longer accepts a custom theme object. Remove the `theme` prop from the `AppProvider` and (optionally) set the `colorScheme` prop to `light` or `dark`: @@ -45,7 +47,7 @@ const App = (props) => ( ) ``` -## Removed all theme types, constants, and utilities +### Removed all theme types, constants, and utilities A number of types, constants, and utilities have been removed with the deprecation of the `ThemeProvider` component: @@ -64,6 +66,10 @@ A number of types, constants, and utilities have been removed with the deprecati - `UNSTABLE_toCssCustomPropertySyntax` - Utility - `UNSTABLE_Tokens` - Constant +### `SkeletonPage` + +The prop `secondaryAction` has been removed and is no longer supported. + ## CSS custom properties CSS custom properties that were renamed can be replaced with the new CSS custom property name. From 7fc060f752c3b14bc7a03654f61de312ec5fc0b0 Mon Sep 17 00:00:00 2001 From: Romello Goodman Date: Thu, 10 Feb 2022 12:47:05 -0500 Subject: [PATCH 2/3] Running prettier --- documentation/guides/migrating-from-v8-to-v9.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/documentation/guides/migrating-from-v8-to-v9.md b/documentation/guides/migrating-from-v8-to-v9.md index 202b3fe1782..11fc9027098 100644 --- a/documentation/guides/migrating-from-v8-to-v9.md +++ b/documentation/guides/migrating-from-v8-to-v9.md @@ -2,7 +2,7 @@ Polaris v9.0.0 ([full release notes](https://github.com/Shopify/polaris-react/releases/tag/v9.0.0)) features removal of the public scss api and removal of scss functions and mixins. -## Components +## Components ### From `ThemeProvider` to `CustomProperties` From 586cdff1ea2679a64d5a982e27bcb7aa7908778c Mon Sep 17 00:00:00 2001 From: Romello Goodman Date: Thu, 10 Feb 2022 13:04:20 -0500 Subject: [PATCH 3/3] Update documentation/guides/migrating-from-v8-to-v9.md Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> --- documentation/guides/migrating-from-v8-to-v9.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/documentation/guides/migrating-from-v8-to-v9.md b/documentation/guides/migrating-from-v8-to-v9.md index 11fc9027098..9801d88da5e 100644 --- a/documentation/guides/migrating-from-v8-to-v9.md +++ b/documentation/guides/migrating-from-v8-to-v9.md @@ -68,7 +68,7 @@ A number of types, constants, and utilities have been removed with the deprecati ### `SkeletonPage` -The prop `secondaryAction` has been removed and is no longer supported. +The prop `secondaryActions` has been removed and is no longer supported. ## CSS custom properties