Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move coverage into build/coverage #533

Merged
merged 1 commit into from Nov 3, 2018
Merged

Move coverage into build/coverage #533

merged 1 commit into from Nov 3, 2018

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Nov 2, 2018

Move code coverage into an already ignored top level folder to avoid
proliferation of top-level ignored files

Simplify the logic for what reporters to use slightly

Tophat

  • Confirm that codecov still picks up the coverage report in the new location, by seeing the codecov check in this PR.
  • Run yarn run test . --no-watch --coverage and see that:
    • A text summary is shown
    • An lcov report is generated at build/coverage/lcov.info
    • A html report is generated and you can open it with open build/coverage/index.html

@BPScott BPScott force-pushed the build-coverage branch 2 times, most recently from c4dacc5 to 1e2e00b Compare November 2, 2018 17:26
Move code coverage into an already ignored top level folder to avoid
proliferation of top-level junk

Simplify the logic for what reporters to use
@BPScott BPScott merged commit 34ddf2f into master Nov 3, 2018
@BPScott BPScott deleted the build-coverage branch November 3, 2018 00:54
@tmlayton tmlayton temporarily deployed to production November 8, 2018 06:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants