From 060b14c1302061a76473fa35040343b71f82b08c Mon Sep 17 00:00:00 2001
From: Sophie Schneider <thesophieschneider@gmail.com>
Date: Thu, 19 Jan 2023 15:50:44 +0000
Subject: [PATCH] Move unit functions to legacy category

---
 .changeset/slow-toys-scream.md |  5 +++++
 stylelint-polaris/index.js     | 20 ++++++++++----------
 2 files changed, 15 insertions(+), 10 deletions(-)
 create mode 100644 .changeset/slow-toys-scream.md

diff --git a/.changeset/slow-toys-scream.md b/.changeset/slow-toys-scream.md
new file mode 100644
index 00000000000..bdb53c7d81a
--- /dev/null
+++ b/.changeset/slow-toys-scream.md
@@ -0,0 +1,5 @@
+---
+'@shopify/stylelint-polaris': patch
+---
+
+Fix incorrect unit function categorization
diff --git a/stylelint-polaris/index.js b/stylelint-polaris/index.js
index 6f9bec86287..be92a11a4f8 100644
--- a/stylelint-polaris/index.js
+++ b/stylelint-polaris/index.js
@@ -218,13 +218,9 @@ const stylelintPolarisCoverageOptions = {
   ],
   spacing: [
     {
-      'function-disallowed-list': [
-        'control-vertical-padding',
-        'em',
-        'px',
-        'rem',
-        'spacing',
-      ].map(matchNameRegExp),
+      'function-disallowed-list': ['control-vertical-padding', 'spacing'].map(
+        matchNameRegExp,
+      ),
       'declaration-property-unit-disallowed-list': [
         {
           '/^padding/': ['px', 'rem', 'em'],
@@ -448,9 +444,13 @@ const stylelintPolarisCoverageOptions = {
         ].map(matchNameRegExp),
       },
       // Legacy functions
-      'function-disallowed-list': ['available-names', 'map-extend'].map(
-        matchNameRegExp,
-      ),
+      'function-disallowed-list': [
+        'available-names',
+        'map-extend',
+        'em',
+        'px',
+        'rem',
+      ].map(matchNameRegExp),
       'polaris/global-disallowed-list': [
         // Legacy variables
         / \* \$/,