diff --git a/.changeset/metal-queens-look.md b/.changeset/metal-queens-look.md new file mode 100644 index 00000000000..62125946049 --- /dev/null +++ b/.changeset/metal-queens-look.md @@ -0,0 +1,6 @@ +--- +'@shopify/stylelint-polaris': minor +'@shopify/polaris': patch +--- + +Disallow text-transform property in Stylelint Polaris diff --git a/polaris-react/src/components/AppProvider/AppProvider.scss b/polaris-react/src/components/AppProvider/AppProvider.scss index ac3b6801023..b2df60bb9d3 100644 --- a/polaris-react/src/components/AppProvider/AppProvider.scss +++ b/polaris-react/src/components/AppProvider/AppProvider.scss @@ -11,6 +11,7 @@ body { line-height: var(--p-font-line-height-2); font-weight: var(--p-font-weight-regular); + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: initial; letter-spacing: initial; diff --git a/polaris-react/src/components/Banner/Banner.scss b/polaris-react/src/components/Banner/Banner.scss index 2d7f183d1db..f5181bef24a 100644 --- a/polaris-react/src/components/Banner/Banner.scss +++ b/polaris-react/src/components/Banner/Banner.scss @@ -265,6 +265,7 @@ font-size: var(--p-font-size-100); font-weight: var(--p-font-weight-medium); line-height: var(--p-font-line-height-1); + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: initial; letter-spacing: initial; color: var(--p-text); diff --git a/polaris-react/src/components/Button/Button.scss b/polaris-react/src/components/Button/Button.scss index 897d93cc02a..e3ae0f30495 100644 --- a/polaris-react/src/components/Button/Button.scss +++ b/polaris-react/src/components/Button/Button.scss @@ -54,6 +54,7 @@ font-size: var(--p-font-size-100); font-weight: var(--p-font-weight-medium); line-height: var(--p-font-line-height-1); + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: initial; letter-spacing: initial; // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY @@ -463,6 +464,7 @@ font-size: var(--p-font-size-200); font-weight: var(--p-font-weight-medium); line-height: var(--p-font-line-height-2); + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: initial; letter-spacing: initial; } diff --git a/polaris-react/src/components/CheckableButton/CheckableButton.scss b/polaris-react/src/components/CheckableButton/CheckableButton.scss index 58fea8a6d25..18866db5d66 100644 --- a/polaris-react/src/components/CheckableButton/CheckableButton.scss +++ b/polaris-react/src/components/CheckableButton/CheckableButton.scss @@ -8,6 +8,7 @@ font-size: var(--p-font-size-75); font-weight: var(--p-font-weight-medium); line-height: var(--p-font-line-height-1); + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: initial; letter-spacing: initial; // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY diff --git a/polaris-react/src/components/FooterHelp/FooterHelp.scss b/polaris-react/src/components/FooterHelp/FooterHelp.scss index ccc6b5767ea..739c0e642e9 100644 --- a/polaris-react/src/components/FooterHelp/FooterHelp.scss +++ b/polaris-react/src/components/FooterHelp/FooterHelp.scss @@ -21,6 +21,7 @@ font-weight: var(--p-font-weight-regular); line-height: var(--p-font-line-height-2); border: none; + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: initial; letter-spacing: initial; } diff --git a/polaris-react/src/components/Frame/Frame.scss b/polaris-react/src/components/Frame/Frame.scss index 4f2abc9695d..77bc606af2f 100644 --- a/polaris-react/src/components/Frame/Frame.scss +++ b/polaris-react/src/components/Frame/Frame.scss @@ -333,6 +333,7 @@ font-size: var(--p-font-size-100); font-weight: var(--p-font-weight-medium); line-height: var(--p-font-line-height-1); + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: initial; letter-spacing: initial; color: var(--p-text); diff --git a/polaris-react/src/components/Navigation/Navigation.scss b/polaris-react/src/components/Navigation/Navigation.scss index 6f20a15d932..f02fded46b3 100644 --- a/polaris-react/src/components/Navigation/Navigation.scss +++ b/polaris-react/src/components/Navigation/Navigation.scss @@ -533,6 +533,7 @@ $disabled-fade: 0.6; } .SectionHeading { + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: none; // Adding this intentionally to override the default subheading styling. // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY display: flex; diff --git a/polaris-react/src/components/Select/Select.scss b/polaris-react/src/components/Select/Select.scss index b318bfed009..30bcb0ede45 100644 --- a/polaris-react/src/components/Select/Select.scss +++ b/polaris-react/src/components/Select/Select.scss @@ -94,6 +94,7 @@ font-size: var(--p-font-size-200); font-weight: var(--p-font-weight-regular); line-height: var(--p-font-line-height-2); + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: initial; letter-spacing: initial; // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY diff --git a/polaris-react/src/components/TextField/TextField.scss b/polaris-react/src/components/TextField/TextField.scss index 97ebe591258..2757764bfb7 100644 --- a/polaris-react/src/components/TextField/TextField.scss +++ b/polaris-react/src/components/TextField/TextField.scss @@ -88,6 +88,7 @@ $spinner-icon-size: 12px; font-size: var(--p-font-size-200); font-weight: var(--p-font-weight-regular); line-height: var(--p-font-line-height-2); + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: initial; letter-spacing: initial; // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY diff --git a/polaris-react/src/styles/shared/_typography.scss b/polaris-react/src/styles/shared/_typography.scss index 03a602e3aaa..4b6dc643267 100644 --- a/polaris-react/src/styles/shared/_typography.scss +++ b/polaris-react/src/styles/shared/_typography.scss @@ -26,6 +26,7 @@ font-size: 13px; font-weight: var(--p-font-weight-semibold); line-height: var(--p-font-line-height-1); + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: uppercase; @media #{$p-breakpoints-md-up} { @@ -39,6 +40,7 @@ line-height: var(--p-font-line-height-3); border: none; + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: initial; letter-spacing: initial; @@ -53,6 +55,7 @@ font-weight: var(--p-font-weight-regular); line-height: var(--p-font-line-height-2); + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: initial; letter-spacing: initial; @@ -67,6 +70,7 @@ font-weight: var(--p-font-weight-medium); line-height: var(--p-font-line-height-1); + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: initial; letter-spacing: initial; @@ -81,6 +85,7 @@ font-weight: var(--p-font-weight-medium); line-height: var(--p-font-line-height-2); + // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY text-transform: initial; letter-spacing: initial; diff --git a/stylelint-polaris/index.js b/stylelint-polaris/index.js index aa43dd3f6d6..99ce5c673b1 100644 --- a/stylelint-polaris/index.js +++ b/stylelint-polaris/index.js @@ -97,6 +97,7 @@ const stylelintPolarisCoverageOptions = { 'line-height': ['px', 'rem', 'em'], }, ], + 'property-disallowed-list': ['text-transform'], 'function-disallowed-list': [ 'font-family', 'font-size',