Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest version of yarn to upgrade Polaris on the style guide #856

Merged
merged 4 commits into from Jan 23, 2019

Conversation

@kaelig
Copy link
Member

commented Jan 11, 2019

WHY are these changes introduced?

ShipIt comes with an old version of Yarn, that doesn't support integrity hashes. This means each polaris-styleguide PR coming from polaris-react deploys is deleting thousands of lines (hashes) from yarn.lock.

WHAT is this pull request doing?

By leveraging a more recent version of Yarn, we know those hashes will be kept in.


To tophat, let's create a new Shipit stack, create a beta version, and see if the resulting PR has a yarn.lock that still contains integrity hashes.

See this PR https://github.com/Shopify/polaris-styleguide/pull/2501/files where the resulting yarn.lock still contains integrity hashes.

@kaelig kaelig requested a review from tmlayton Jan 11, 2019

@kaelig

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

Here's what this PR is attempting to fix (seen in this PR):

screenshot_2019-01-10_16_13_16

@kaelig kaelig force-pushed the yarn-latest branch from 9a2b579 to a37155b Jan 11, 2019

@BPScott

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

@latest is potentially a big aggressive given that we have to opt into new dev versions of it via dev, but I think it's better than the alternative of having up update every so often.

@BPScott BPScott temporarily deployed to polaris-react-pr-856 Jan 11, 2019 Inactive

@kaelig

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

I agree it may be a bit optimistic / aggressive. Changed it to 10.13.0 instead!

@kaelig kaelig temporarily deployed to polaris-react-pr-856 Jan 11, 2019 Inactive

@@ -11,6 +11,7 @@ const polarisBotName = 'Shopify Polaris Bot';
const polarisBotEmail = 'shopify-polaris-bot@users.noreply.github.com';
const polarisBotToken = require('../secrets.json').github['shopify-polaris'];

const YARN_VERSION = '10.13.0';

This comment has been minimized.

Copy link
@tmlayton

tmlayton Jan 12, 2019

Member

Can we pull the version number from the yml file?

This comment has been minimized.

Copy link
@tmlayton

This comment has been minimized.

Copy link
@kaelig

kaelig Jan 13, 2019

Author Member

Oh wait... That's the node version, not Yarn. Silly me. I'll revert that last change.

This comment has been minimized.

Copy link
@kaelig

kaelig Jan 14, 2019

Author Member

Done in de7dbfe. Can you have a look?

@kaelig kaelig force-pushed the yarn-latest branch from b59ddcd to de7dbfe Jan 14, 2019

@kaelig kaelig temporarily deployed to polaris-react-pr-856 Jan 14, 2019 Inactive

@dpersing

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

@kaelig @BPScott @tmlayton Looks like this is ready to merge?

kaelig added 4 commits Jan 11, 2019
Use the latest version of yarn to upgrade Polaris on the style guide
ShipIt comes with an old version of Yarn, that doesn't support integrity hashes. This means each polaris-styleguide PR coming from polaris-react deploys is deleting thousands of lines (hashes) from yarn.lock.

By leveraging the latest version of Yarn, we know those hashes will be kept in.

@kaelig kaelig force-pushed the yarn-latest branch from de7dbfe to 70e5179 Jan 23, 2019

@kaelig kaelig merged commit 597f76f into master Jan 23, 2019

8 checks passed

CLA Contributor License Agreement (CLA) status
Details
WIP ready for review
Details
changelog changelog entry included
Details
ci/circleci: check Your tests passed on CircleCI!
Details
ci/circleci: percy Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing c244612...70e5179
Details
percy/polaris-react Visual review automatically approved, no visual changes found.
Details
shrink-ray Webpack build report complete :)
Details

@kaelig kaelig deleted the yarn-latest branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.