diff --git a/.changeset/fast-glasses-rhyme.md b/.changeset/fast-glasses-rhyme.md new file mode 100644 index 00000000000..f52caa148be --- /dev/null +++ b/.changeset/fast-glasses-rhyme.md @@ -0,0 +1,5 @@ +--- +'@shopify/stylelint-polaris': major +--- + +Turn on reportNeedlessDisables for all comments diff --git a/stylelint-polaris/index.js b/stylelint-polaris/index.js index 29e1557e290..4f1b9497bf1 100644 --- a/stylelint-polaris/index.js +++ b/stylelint-polaris/index.js @@ -504,15 +504,7 @@ const stylelintPolarisCoverageOptions = { module.exports = { customSyntax: 'postcss-scss', reportDescriptionlessDisables: true, - reportNeedlessDisables: [ - true, - { - // Report needless disables for all rules except layout coverage rules - // Note: This doesn't affect the default Stylelint behavior/reporting - // and is only need because we dynamically create these rule names - except: ['all', /^polaris\/layout\/.+$/], - }, - ], + reportNeedlessDisables: true, reportInvalidScopeDisables: [ true, {