From e179124c2be24ccde6a24578c2a391639f6780b6 Mon Sep 17 00:00:00 2001 From: Alex Page Date: Tue, 14 Mar 2023 14:10:26 +1100 Subject: [PATCH 1/2] Update index.js --- stylelint-polaris/index.js | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/stylelint-polaris/index.js b/stylelint-polaris/index.js index 29e1557e290..4f1b9497bf1 100644 --- a/stylelint-polaris/index.js +++ b/stylelint-polaris/index.js @@ -504,15 +504,7 @@ const stylelintPolarisCoverageOptions = { module.exports = { customSyntax: 'postcss-scss', reportDescriptionlessDisables: true, - reportNeedlessDisables: [ - true, - { - // Report needless disables for all rules except layout coverage rules - // Note: This doesn't affect the default Stylelint behavior/reporting - // and is only need because we dynamically create these rule names - except: ['all', /^polaris\/layout\/.+$/], - }, - ], + reportNeedlessDisables: true, reportInvalidScopeDisables: [ true, { From 52b167508f68be3ca6a116674a223188d62963a7 Mon Sep 17 00:00:00 2001 From: Alex Page Date: Tue, 14 Mar 2023 14:24:47 +1100 Subject: [PATCH 2/2] Create fast-glasses-rhyme.md --- .changeset/fast-glasses-rhyme.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/fast-glasses-rhyme.md diff --git a/.changeset/fast-glasses-rhyme.md b/.changeset/fast-glasses-rhyme.md new file mode 100644 index 00000000000..f52caa148be --- /dev/null +++ b/.changeset/fast-glasses-rhyme.md @@ -0,0 +1,5 @@ +--- +'@shopify/stylelint-polaris': major +--- + +Turn on reportNeedlessDisables for all comments