From 395b08eaf3f3a5043878345fe987818df897cd66 Mon Sep 17 00:00:00 2001 From: Marc Thomas Date: Tue, 11 Apr 2023 10:43:06 +0100 Subject: [PATCH 1/3] chore: vertical align the filter pill --- .changeset/little-ravens-repair.md | 5 +++++ polaris-react/src/components/AlphaFilters/AlphaFilters.scss | 1 + .../AlphaFilters/components/FilterPill/FilterPill.scss | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 .changeset/little-ravens-repair.md diff --git a/.changeset/little-ravens-repair.md b/.changeset/little-ravens-repair.md new file mode 100644 index 00000000000..1e0d9d52a7a --- /dev/null +++ b/.changeset/little-ravens-repair.md @@ -0,0 +1,5 @@ +--- +'@shopify/polaris': patch +--- + +Tweaked the vertical alignment of elements within the `AlphaFilters` component diff --git a/polaris-react/src/components/AlphaFilters/AlphaFilters.scss b/polaris-react/src/components/AlphaFilters/AlphaFilters.scss index ac4dde7e0a1..49db7b102c0 100644 --- a/polaris-react/src/components/AlphaFilters/AlphaFilters.scss +++ b/polaris-react/src/components/AlphaFilters/AlphaFilters.scss @@ -216,6 +216,7 @@ .ClearAll { margin-left: var(--p-space-1); + transform: translateY(-1px); } @media #{$p-breakpoints-md-down} { diff --git a/polaris-react/src/components/AlphaFilters/components/FilterPill/FilterPill.scss b/polaris-react/src/components/AlphaFilters/components/FilterPill/FilterPill.scss index 472fc9f3666..ed81c19b99d 100644 --- a/polaris-react/src/components/AlphaFilters/components/FilterPill/FilterPill.scss +++ b/polaris-react/src/components/AlphaFilters/components/FilterPill/FilterPill.scss @@ -73,7 +73,7 @@ } .Label { - display: block; + display: flex; padding-left: var(--p-space-05); } } From 523e11c43ffdb5b421d41fa008716a5b1c8282f0 Mon Sep 17 00:00:00 2001 From: Marc Thomas Date: Wed, 12 Apr 2023 17:08:24 +0100 Subject: [PATCH 2/3] chore: use micro button for clear all link: --- .../src/components/AlphaFilters/AlphaFilters.tsx | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/polaris-react/src/components/AlphaFilters/AlphaFilters.tsx b/polaris-react/src/components/AlphaFilters/AlphaFilters.tsx index 8ea04034a6a..3f4befa3762 100644 --- a/polaris-react/src/components/AlphaFilters/AlphaFilters.tsx +++ b/polaris-react/src/components/AlphaFilters/AlphaFilters.tsx @@ -10,10 +10,10 @@ import {Text} from '../Text'; import {UnstyledButton} from '../UnstyledButton'; import {classNames} from '../../utilities/css'; import type {AppliedFilterInterface, FilterInterface} from '../../types'; -import {Link} from '../Link'; import {HorizontalStack} from '../HorizontalStack'; import {Box} from '../Box'; import {Spinner} from '../Spinner'; +import {Button} from '../Button'; import {FilterPill, SearchField} from './components'; import styles from './AlphaFilters.scss'; @@ -329,11 +329,14 @@ export function AlphaFilters({ styles.MultiplePinnedFilterClearAll, )} > - - - {i18n.translate('Polaris.Filters.clearFilters')} - - + ) : null; From 8287ed3ef1ca44237c150f7a807d6893157838cb Mon Sep 17 00:00:00 2001 From: Marc Thomas Date: Wed, 12 Apr 2023 19:09:50 +0100 Subject: [PATCH 3/3] chore: remove transform --- polaris-react/src/components/AlphaFilters/AlphaFilters.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/polaris-react/src/components/AlphaFilters/AlphaFilters.scss b/polaris-react/src/components/AlphaFilters/AlphaFilters.scss index 49db7b102c0..ac4dde7e0a1 100644 --- a/polaris-react/src/components/AlphaFilters/AlphaFilters.scss +++ b/polaris-react/src/components/AlphaFilters/AlphaFilters.scss @@ -216,7 +216,6 @@ .ClearAll { margin-left: var(--p-space-1); - transform: translateY(-1px); } @media #{$p-breakpoints-md-down} {