From 355500df89520e95ce67f3669d109ad8b006e125 Mon Sep 17 00:00:00 2001
From: Sam Rose <11774595+samrose3@users.noreply.github.com>
Date: Wed, 26 Apr 2023 08:05:50 -0400
Subject: [PATCH] Re-enable layout warnings for coverage rules

---
 .changeset/stale-tools-allow.md |  5 +++
 stylelint-polaris/index.js      | 75 +++++++++++++++++----------------
 2 files changed, 43 insertions(+), 37 deletions(-)
 create mode 100644 .changeset/stale-tools-allow.md

diff --git a/.changeset/stale-tools-allow.md b/.changeset/stale-tools-allow.md
new file mode 100644
index 00000000000..e5572586378
--- /dev/null
+++ b/.changeset/stale-tools-allow.md
@@ -0,0 +1,5 @@
+---
+'@shopify/stylelint-polaris': minor
+---
+
+Re-enabled layout warnings for coverage rules
diff --git a/stylelint-polaris/index.js b/stylelint-polaris/index.js
index 53b26331116..3413f074802 100644
--- a/stylelint-polaris/index.js
+++ b/stylelint-polaris/index.js
@@ -387,42 +387,42 @@ const stylelintPolarisCoverageOptions = {
   },
   layout: [
     {
-      // 'declaration-property-value-disallowed-list': [
-      //   {
-      //     top: [/(?!var\(--p-).+$/],
-      //     bottom: [/(?!var\(--p-).+$/],
-      //     left: [/(?!var\(--p-).+$/],
-      //     right: [/(?!var\(--p-).+$/],
-      //     '/^width/': [/(?!var\(--p-).+$/],
-      //     '/^height/': [/(?!var\(--p-).+$/],
-      //   },
-      //   {severity: 'warning'},
-      // ],
-      // 'property-disallowed-list': [
-      //   [
-      //     'position',
-      //     'grid',
-      //     'flex',
-      //     'flex-grow',
-      //     'flex-shrink',
-      //     'flex-basis',
-      //     'justify-content',
-      //     'align-items',
-      //     'grid-row',
-      //     'grid-row-start',
-      //     'grid-row-end',
-      //     'grid-column',
-      //     'grid-column-start',
-      //     'grid-column-end',
-      //     'grid-template',
-      //     'grid-template-areas',
-      //     'grid-template-rows',
-      //     'grid-template-columns',
-      //     'grid-area',
-      //     'display',
-      //   ],
-      //   {severity: 'warning'},
-      // ],
+      'declaration-property-value-disallowed-list': [
+        {
+          top: [/(?!var\(--p-).+$/],
+          bottom: [/(?!var\(--p-).+$/],
+          left: [/(?!var\(--p-).+$/],
+          right: [/(?!var\(--p-).+$/],
+          '/^width/': [/(?!var\(--p-).+$/],
+          '/^height/': [/(?!var\(--p-).+$/],
+        },
+        {severity: 'warning'},
+      ],
+      'property-disallowed-list': [
+        [
+          'position',
+          'grid',
+          'flex',
+          'flex-grow',
+          'flex-shrink',
+          'flex-basis',
+          'justify-content',
+          'align-items',
+          'grid-row',
+          'grid-row-start',
+          'grid-row-end',
+          'grid-column',
+          'grid-column-start',
+          'grid-column-end',
+          'grid-template',
+          'grid-template-areas',
+          'grid-template-rows',
+          'grid-template-columns',
+          'grid-area',
+          'display',
+        ],
+        {severity: 'warning'},
+      ],
       'function-disallowed-list': [
         'nav-min-window-corrected',
         'control-height',
@@ -449,7 +449,8 @@ const stylelintPolarisCoverageOptions = {
       ],
     },
     {
-      message: 'Please use a Polaris layout component',
+      message:
+        'Consider using a Polaris layout component if applicable for this layout style',
     },
   ],
   legacy: [