Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover] Remove duplicate `activatorWrapper` prop #916

Merged
merged 1 commit into from Jan 22, 2019

Conversation

@beefchimi
Copy link
Member

commented Jan 22, 2019

Was cruisin' through the code and noticed the had duplicated a prop. Simple one line removal!

@beefchimi beefchimi self-assigned this Jan 22, 2019

@beefchimi beefchimi requested a review from dleroux Jan 22, 2019

@BPScott BPScott temporarily deployed to polaris-react-pr-916 Jan 22, 2019 Inactive

@dleroux
Copy link
Contributor

left a comment

Maybe a change log entry?

@beefchimi

This comment has been minimized.

Copy link
Member Author

commented Jan 22, 2019

@daniedleroux updated UNRELEASED.md 👍

Will ship once green

@beefchimi beefchimi merged commit 6292f38 into master Jan 22, 2019

8 checks passed

CLA Contributor License Agreement (CLA) status
Details
WIP ready for review
Details
changelog changelog entry included
Details
ci/circleci: check Your tests passed on CircleCI!
Details
ci/circleci: percy Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 34aa4e4...118f7d7
Details
percy/polaris-react Visual review automatically approved, no visual changes found.
Details
shrink-ray Webpack build report complete :)
Details

@beefchimi beefchimi deleted the popover-dupe-activator-wrapper branch Jan 22, 2019

@BPScott BPScott deployed to production Jan 28, 2019 Active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.