From 6e2ccb62268936f7a2c8f81d89a1deec19b3eed9 Mon Sep 17 00:00:00 2001 From: aveline Date: Tue, 16 May 2023 08:49:42 -0700 Subject: [PATCH 1/3] Deprecate `external` prop in `Link` component --- polaris-react/src/components/Link/Link.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/polaris-react/src/components/Link/Link.tsx b/polaris-react/src/components/Link/Link.tsx index 1535ff01456..9548f6f750e 100644 --- a/polaris-react/src/components/Link/Link.tsx +++ b/polaris-react/src/components/Link/Link.tsx @@ -14,7 +14,9 @@ export interface LinkProps { url?: string; /** The content to display inside the link */ children?: React.ReactNode; - /** Makes the link open in a new tab */ + /** Makes the link open in a new tab + * @deprecated use `target` instead + */ external?: boolean; /** Where to display the url */ target?: Target; From 8e9ae9f45f8d8c13adb715717bfe19d215083895 Mon Sep 17 00:00:00 2001 From: aveline Date: Tue, 16 May 2023 08:53:42 -0700 Subject: [PATCH 2/3] Update Link.tsx --- polaris-react/src/components/Link/Link.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/polaris-react/src/components/Link/Link.tsx b/polaris-react/src/components/Link/Link.tsx index 9548f6f750e..32da4103e6f 100644 --- a/polaris-react/src/components/Link/Link.tsx +++ b/polaris-react/src/components/Link/Link.tsx @@ -15,7 +15,7 @@ export interface LinkProps { /** The content to display inside the link */ children?: React.ReactNode; /** Makes the link open in a new tab - * @deprecated use `target` instead + * @deprecated use `target` set to `_blank` instead */ external?: boolean; /** Where to display the url */ From cac6412a38d3270a5420a2cdc2634cc085f62662 Mon Sep 17 00:00:00 2001 From: aveline Date: Fri, 2 Jun 2023 08:49:04 -0700 Subject: [PATCH 3/3] changeset --- .changeset/nine-cycles-invent.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/nine-cycles-invent.md diff --git a/.changeset/nine-cycles-invent.md b/.changeset/nine-cycles-invent.md new file mode 100644 index 00000000000..5cfc529db46 --- /dev/null +++ b/.changeset/nine-cycles-invent.md @@ -0,0 +1,5 @@ +--- +'@shopify/polaris': patch +--- + +Deprecated `external` prop in `Link` component