From 20789f2eda708e3dbfcf7350f06562273596c2a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexandre=20C=C3=B4t=C3=A9?= Date: Tue, 2 May 2023 15:55:57 -0400 Subject: [PATCH] Removing onCompleted and onError from the useQuery --- .changeset/breezy-dolphins-exercise.md | 5 +++++ packages/react-graphql/src/hooks/types.ts | 7 ++++++- 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 .changeset/breezy-dolphins-exercise.md diff --git a/.changeset/breezy-dolphins-exercise.md b/.changeset/breezy-dolphins-exercise.md new file mode 100644 index 0000000000..f5e553bba1 --- /dev/null +++ b/.changeset/breezy-dolphins-exercise.md @@ -0,0 +1,5 @@ +--- +'@shopify/react-graphql': patch +--- + +Remove `onCompleted` and `onError` from the types on `useQuery`'s options as they are not implemented diff --git a/packages/react-graphql/src/hooks/types.ts b/packages/react-graphql/src/hooks/types.ts index e964b58799..4af639a91e 100644 --- a/packages/react-graphql/src/hooks/types.ts +++ b/packages/react-graphql/src/hooks/types.ts @@ -13,7 +13,12 @@ import type {VariableOptions} from '../types'; export type QueryHookOptions = Omit< QueryComponentOptions, - 'query' | 'partialRefetch' | 'children' | 'variables' + | 'query' + | 'partialRefetch' + | 'children' + | 'variables' + | 'onCompleted' + | 'onError' > & VariableOptions & { skip?: boolean;