Fix stateful subscribable overwriting updates #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a particular edge case I was hitting with remote subscribables that I don't think is actually possible when using them across
postMessage()
(as they are intended to be used), but was possible when they ran in the same JavaScript environment (e.g., for tests):This PR fixes the issue by not taking the "connection result" value as the most up-to-date value if we have already started receiving updates through our subscriber.