Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support memory operands to push in assembler #58

Merged
merged 1 commit into from Feb 26, 2021

Conversation

tekknolagi
Copy link

@tekknolagi tekknolagi commented Feb 26, 2021

No description provided.

@tekknolagi tekknolagi changed the title Support memory operands to push Support memory operands to push in assembler Feb 26, 2021
@maximecb
Copy link

Nice. Glad you also added tests 👍

I use yasm to look at the bytes it produces for instructions and use that as reference. Here is a little script yasm.sh to print the output encoding bytes for some instruction:

echo "$*" > /tmp/test.s
yasm -o /dev/null -f elf64 -O2 -l /tmp/test.txt /tmp/test.s
cat /tmp/test.txt

eg:

> ./yasm.sh "push qword[R8 + 8*RCX + 3]"
     1                                 %line 1+1 /tmp/test.s
     2 00000000 41FF74C803             push qword[R8 + 8*RCX + 3]

I'm getting the same output you have here, so it looks good to me :)

@maximecb maximecb merged commit 17e3fc2 into Shopify:microjit Feb 26, 2021
tenderlove pushed a commit that referenced this pull request Jun 2, 2021
* Add ETYPE_TRUE and ETYPE_FALSE

* Implement checktype

* Implement concatstrings

* Update deps
maximecb pushed a commit that referenced this pull request Oct 19, 2021
* Add ETYPE_TRUE and ETYPE_FALSE

* Implement checktype

* Implement concatstrings

* Update deps
noahgibbs pushed a commit that referenced this pull request Oct 20, 2021
* Add ETYPE_TRUE and ETYPE_FALSE

* Implement checktype

* Implement concatstrings

* Update deps
XrXr pushed a commit that referenced this pull request Oct 20, 2021
* Add ETYPE_TRUE and ETYPE_FALSE

* Implement checktype

* Implement concatstrings

* Update deps
XrXr pushed a commit that referenced this pull request Oct 20, 2021
* Add ETYPE_TRUE and ETYPE_FALSE

* Implement checktype

* Implement concatstrings

* Update deps
XrXr pushed a commit that referenced this pull request Oct 21, 2021
* Add ETYPE_TRUE and ETYPE_FALSE

* Implement checktype

* Implement concatstrings

* Update deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants