Add support for Go 1.13 #1478
Merged
Add support for Go 1.13 #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bai
commented
Sep 4, 2019
| @@ -1,5 +1,7 @@ | |||
| module github.com/Shopify/sarama | |||
|
|
|||
| go 1.13 | |||
There was a problem hiding this comment.
@varun06 I'm not 100% this is needed (this line added by go mod), do you know if it's something that will break 1.11/1.12 compatibility?
According to https://golang.org/doc/go1.13 it shouldn't but 🤔:
If your code uses modules and your go.mod files specifies a language version, be sure it is set to at least 1.13 to get access to these language changes. You can do this by editing the go.mod file directly, or you can run go mod edit -go=1.13.
There was a problem hiding this comment.
yeah, I treat it like a ceiling for go features. So it shouldn't impact anything with backward compatibility.
d1egoaz
reviewed
Sep 4, 2019
|
|
||
| Sarama provides a "2 releases + 2 months" compatibility guarantee: we support | ||
| the two latest stable releases of Kafka and Go, and we provide a two month | ||
| grace period for older releases. This means we currently officially support | ||
| Go 1.11 through 1.12, and Kafka 2.0 through 2.3, although older releases are | ||
| Go 1.11 through 1.13, and Kafka 2.1 through 2.3, although older releases are |
There was a problem hiding this comment.
is this compatibility matrix important?
are we even following it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Go 1.13 and remove Kafka 2.1 from build matrix according to 2 releases + 2 months schedule.