Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed variable names that are named same as some std lib package names #1738

Merged
merged 3 commits into from Jul 15, 2020

Conversation

varun06
Copy link
Collaborator

@varun06 varun06 commented Jun 28, 2020

This is part of cleaning up some of the Lint and Vet issues. This is first PR in list of many PR's.

@varun06 varun06 requested a review from bai as a code owner Jun 28, 2020
@varun06 varun06 requested a review from d1egoaz Jun 28, 2020
Copy link
Contributor

@d1egoaz d1egoaz left a comment

just a couple of comments.
otherwise this looks great to me, I look forward for all the lint fixes! thanks for doing this! ❤️

.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
async_producer_test.go Outdated Show resolved Hide resolved
async_producer_test.go Outdated Show resolved Hide resolved
async_producer_test.go Outdated Show resolved Hide resolved
consumer.go Show resolved Hide resolved
Copy link
Contributor

@d1egoaz d1egoaz left a comment

🚀

@varun06 varun06 requested a review from dnwe Jul 5, 2020
@d1egoaz d1egoaz merged commit 4bc9b8f into Shopify:master Jul 15, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants