Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kafka 2.6.0 #1769

Merged
merged 1 commit into from Aug 5, 2020
Merged

Add support for Kafka 2.6.0 #1769

merged 1 commit into from Aug 5, 2020

Conversation

bai
Copy link
Contributor

@bai bai commented Aug 5, 2020

Add support for Kafka 2.6.0 馃

@bai bai requested a review from dnwe Aug 5, 2020
dnwe
dnwe approved these changes Aug 5, 2020
@@ -119,7 +119,7 @@ func prepareDockerTestEnvironment(ctx context.Context, env *testEnvironment) err
// found here: https://docs.confluent.io/current/installation/versions-interoperability.html
var confluentPlatformVersion string
switch env.KafkaVersion {
Copy link
Collaborator

@dnwe dnwe Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remember to bump confluentPlatformVersion to 5.6 once images from that are available I guess. Probably worth opening a backlog issue so we don鈥檛 forget.

I did also wonder if we should move to strimzi/kafka for our CI image

Copy link
Contributor Author

@bai bai Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we use a mix of confluent-oss and wurstmeister/kafka internally on CI. /cc @d1egoaz

Copy link
Contributor

@d1egoaz d1egoaz Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either should work, 馃し ideally, we should only use one flavour

@bai bai merged commit c4bb5cd into master Aug 5, 2020
5 checks passed
@bai bai deleted the kafka260 branch Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants