Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIP-392: Allow consumers to fetch from closest replica #1822

Merged
merged 4 commits into from Nov 6, 2020

Conversation

danp
Copy link
Contributor

@danp danp commented Oct 29, 2020

Support for KIP-392 in Sarama consumers.

This is a continuation of #1696 with changes mentioned here.

Co-authored-by: "Deepak.Neralla" Deepak.Neralla@mixpanel.com

dneralla and others added 4 commits May 11, 2020
Address comments on Shopify#1696.

Change to only adding and using a new preferredReadReplica field.

Move setting of the preferredReadReplica field up in
parseResponse. This causes the returned preferred read replica to be
used even if there are no records in the fetch response.

Set FetchResponse.PreferredReadReplica to -1 when decoding versions
prior to 11.

Add more tests.

Change consumeMsgs in functional tests to use subtests to reduce
number of outstanding connections.
@danp
Copy link
Contributor Author

danp commented Oct 29, 2020

I signed the CLA.

@bai bai requested review from d1egoaz and dnwe Oct 29, 2020
dnwe
dnwe approved these changes Nov 6, 2020
@dnwe dnwe changed the title KIP-392: Continue work on #1696 KIP-392: Allow consumers to fetch from closest replica Nov 6, 2020
@dnwe dnwe merged commit 22788cc into Shopify:master Nov 6, 2020
3 checks passed
@dnwe
Copy link
Collaborator

dnwe commented Nov 6, 2020

@dneralla many thanks to both yourself and @danp for putting together this much requested feature! changes look good, I've approved and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants