Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore Consumer.Offsets.AutoCommit.Enable config on Close #1846

Merged
merged 2 commits into from Jan 13, 2021

Conversation

wclaeys
Copy link
Contributor

@wclaeys wclaeys commented Nov 27, 2020

Adds om.conf.Consumer.Offsets.AutoCommit.Enable during closing of the offset_manager and hence fixing #1843

@wclaeys wclaeys requested a review from bai as a code owner Nov 27, 2020
@bai bai requested review from d1egoaz and dnwe Nov 27, 2020
@wclaeys
Copy link
Contributor Author

wclaeys commented Dec 7, 2020

Can somebody kick the builds again please, looks like a test environment issue. Thx!

@d1egoaz
Copy link
Contributor

d1egoaz commented Jan 12, 2021

@wclaeys can you try:

git commit --allow-empty -m "trigger GitHub actions"
git push

I don't see the option to re-run the action. It might be configured to run only when pushed

@bai
Copy link
Contributor

bai commented Jan 12, 2021

This PR needs to be rebased off of master — it uses no longer supported GitHub Actions features that were fixed in master recently.

bai
bai approved these changes Jan 13, 2021
@bai bai merged commit ceadf4f into Shopify:master Jan 13, 2021
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants