Permalink
Browse files

Upgrade to Rubocop 0.52, update config accordingly, and whitelist som…

…e new style issues.
  • Loading branch information...
wvanbergen committed Feb 27, 2018
1 parent 956757b commit 4c1cc8f33874a787bd290b4cb67982d22f005c20
Showing with 29 additions and 16 deletions.
  1. +1 −1 .rubocop.yml
  2. +22 −8 .rubocop_todo.yml
  3. +1 −1 Gemfile
  4. +5 −6 Gemfile.lock
@@ -31,7 +31,7 @@ Rails/SkipsModelValidations:
Lint/RescueException:
Enabled: false
Lint/RescueWithoutErrorClass:
Style/RescueStandardError:
Enabled: false
Lint/AssignmentInCondition:
@@ -1,14 +1,14 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2018-02-27 04:51:14 -0500 using RuboCop version 0.50.0.
# on 2018-02-27 04:59:33 -0500 using RuboCop version 0.52.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
# Offense count: 3
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# Configuration parameters: EnforcedStyle, IndentationWidth.
# SupportedStyles: with_first_parameter, with_fixed_indentation
Layout/AlignParameters:
Exclude:
@@ -17,7 +17,7 @@ Layout/AlignParameters:
# Offense count: 6
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
Layout/IndentHeredoc:
Exclude:
@@ -49,13 +49,13 @@ Rails/ApplicationJob:
- 'app/jobs/shipit/background_job.rb'
# Offense count: 1
# Configuration parameters: EnforcedStyle, SupportedStyles.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: strict, flexible
Rails/Date:
Exclude:
- 'test/models/status_test.rb'
# Offense count: 12
# Offense count: 10
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/HasManyOrHasOneDependent:
@@ -67,8 +67,22 @@ Rails/HasManyOrHasOneDependent:
- 'app/models/shipit/team.rb'
- 'app/models/shipit/user.rb'
# Offense count: 17
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/InverseOf:
Exclude:
- 'app/models/shipit/api_client.rb'
- 'app/models/shipit/commit.rb'
- 'app/models/shipit/commit_deployment.rb'
- 'app/models/shipit/pull_request.rb'
- 'app/models/shipit/rollback.rb'
- 'app/models/shipit/stack.rb'
- 'app/models/shipit/task.rb'
- 'app/models/shipit/team.rb'
# Offense count: 22
# Configuration parameters: EnforcedStyle, SupportedStyles.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: strict, flexible
Rails/TimeZone:
Exclude:
@@ -87,7 +101,7 @@ Security/JSONLoad:
# Offense count: 9
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: compact, expanded
Style/EmptyMethod:
Exclude:
@@ -107,7 +121,7 @@ Style/SymbolProc:
# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: all_comparison_operators, equality_operators_only
Style/YodaCondition:
Exclude:
@@ -12,7 +12,7 @@ end
group :development, :test do
gem 'faker'
gem 'fakeweb'
gem 'rubocop', '~> 0.51.0'
gem 'rubocop', '~> 0.52.0'
end
group :test do
@@ -215,8 +215,7 @@ GEM
method_source
rake (>= 0.8.7)
thor (>= 0.18.1, < 2.0)
rainbow (2.2.2)
rake
rainbow (3.0.0)
rake (10.5.0)
rb-fsevent (0.10.2)
rb-inotify (0.9.10)
@@ -229,11 +228,11 @@ GEM
responders (2.4.0)
actionpack (>= 4.2.0, < 5.3)
railties (>= 4.2.0, < 5.3)
rubocop (0.51.0)
rubocop (0.52.1)
parallel (~> 1.10)
parser (>= 2.3.3.1, < 3.0)
parser (>= 2.4.0.2, < 3.0)
powerpack (~> 0.1)
rainbow (>= 2.2.2, < 3.0)
rainbow (>= 2.2.2, < 4.0)
ruby-progressbar (~> 1.7)
unicode-display_width (~> 1.0, >= 1.0.1)
ruby-progressbar (1.9.0)
@@ -304,7 +303,7 @@ DEPENDENCIES
mysql2
pg
pry
rubocop (~> 0.51.0)
rubocop (~> 0.52.0)
shipit-engine!
simplecov
spy

0 comments on commit 4c1cc8f

Please sign in to comment.