Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rake deploy command #895

Merged
merged 1 commit into from May 16, 2019

Conversation

Projects
None yet
3 participants
@doodzik
Copy link
Member

commented Apr 17, 2019

This command gives the ability to trigger a deploy through the command line interface when sshed into a running Shipit Instance. This is useful when the UI isn't responsive.

@doodzik doodzik force-pushed the rake_deploy branch 14 times, most recently from 7c53c40 to d18ffb8 Apr 17, 2019

Show resolved Hide resolved Rakefile Outdated
Show resolved Hide resolved test/models/stacks_test.rb Outdated

@doodzik doodzik marked this pull request as ready for review Apr 18, 2019

@doodzik doodzik changed the title [WIP] add rake deploy command Add rake deploy command Apr 18, 2019

@doodzik doodzik requested a review from Shopify/pipeline Apr 18, 2019

Show resolved Hide resolved test/models/stacks_test.rb Outdated
Show resolved Hide resolved app/models/shipit/task.rb Outdated
@JackTLi
Copy link
Member

left a comment

Few little comments, things look really good otherwise! Great work on this 🎉

Show resolved Hide resolved app/models/shipit/stack.rb Outdated
Show resolved Hide resolved app/models/shipit/task.rb Outdated
Show resolved Hide resolved app/models/shipit/stack.rb Outdated
Show resolved Hide resolved Rakefile Outdated

@doodzik doodzik force-pushed the rake_deploy branch 3 times, most recently from e3dd952 to 7eb29b4 May 14, 2019

@doodzik doodzik requested review from Shopify/pipeline and DazWorrall and removed request for DazWorrall May 14, 2019

@doodzik doodzik requested review from JackTLi and DazWorrall May 14, 2019

Show resolved Hide resolved test/models/stacks_test.rb Outdated
@JackTLi
Copy link
Member

left a comment

Just the single comment on the test case, otherwise things lgtm 👍

@DazWorrall
Copy link
Member

left a comment

🎉

Can you share a screenshot of how this looks in your terminal? Not setup with a working dev env on my new laptop yet.

Show resolved Hide resolved Rakefile Outdated
Show resolved Hide resolved app/models/shipit/command_line_user.rb
Show resolved Hide resolved app/models/shipit/stack.rb Outdated

@doodzik doodzik force-pushed the rake_deploy branch 4 times, most recently from 027ca68 to 062e819 May 16, 2019

@doodzik

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

Screen Shot 2019-05-16 at 15 06 03

Ran it in production. It deployed successfully and it logged locally and on the web ui simultaneously.

@doodzik doodzik force-pushed the rake_deploy branch from 062e819 to 2209890 May 16, 2019

@doodzik doodzik merged commit ad07773 into master May 16, 2019

3 checks passed

CLA Contributor License Agreement (CLA) status
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.