Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global `Process.kill` stub in tests #905

Merged
merged 1 commit into from May 14, 2019

Conversation

Projects
None yet
3 participants
@DazWorrall
Copy link
Member

commented May 13, 2019

I lost a bunch of time to this while working on #882, and the suite is green without it so let's 馃敟

@DazWorrall DazWorrall requested review from wvanbergen and JackTLi May 13, 2019

@JackTLi
Copy link
Member

left a comment

Looks like all of the tests are running correctly (no early pkill)

@wvanbergen
Copy link
Member

left a comment

Yeah - not sure why this once was added but it looks like a decidedly bad idea. 馃敟

@DazWorrall DazWorrall merged commit e3d982a into master May 14, 2019

3 checks passed

CLA Contributor License Agreement (CLA) status
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@DazWorrall DazWorrall deleted the unstub-process-kill branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.