Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle permissions errors getting user emails #933

Merged
merged 2 commits into from Aug 15, 2019
Merged

Handle permissions errors getting user emails #933

merged 2 commits into from Aug 15, 2019

Conversation

DazWorrall
Copy link
Member

I'm spinning my wheels fixing the tests for this, going to ship from this branch to get us going again.

@DazWorrall
Copy link
Member Author

DazWorrall commented Aug 15, 2019 •
edited

There was an issue with the tests here - without Shipit.preferred_org_emails = [@org_domain] appropriate_email_for was short circuiting early. I changed the stubs for expectations to see them fail, then added the config stub.

@DazWorrall DazWorrall merged commit 0b0cd8a into master Aug 15, 2019
@DazWorrall DazWorrall deleted the email-hotix branch August 15, 2019 17:40
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems August 15, 2019 18:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvanbergen wvanbergen wvanbergen approved these changes

@ajshepley ajshepley ajshepley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DazWorrall @wvanbergen @ajshepley