Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing CI with greater clarity #939

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@DazWorrall
Copy link
Member

commented Sep 6, 2019

The tests were very wrong here I think. The fixture deploy spec doesn't require any CI at all - so nothing could ever be missing - and the titles of the tests say we should reject missing CI, when in reality they were asserting the opposite. This fixes the tests, and adds a new reason ci_missing, to give greater clarity to users when this is the rejection reason. I follow up with a spy PR before shipping this.

@DazWorrall DazWorrall requested review from wvanbergen, byroot and Shopify/pipeline Sep 6, 2019

@byroot
byroot approved these changes Sep 6, 2019
Copy link
Collaborator

left a comment

👍

@DazWorrall DazWorrall merged commit 690f28a into master Sep 9, 2019

3 checks passed

CLA Contributor License Agreement (CLA) status
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@DazWorrall DazWorrall deleted the better-handle-ci-missing branch Sep 9, 2019

@shopify-shipit shopify-shipit bot deployed to rubygems Sep 9, 2019 Active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.