Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various optimizations to reduce git lock contention #942

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@casperisfine
Copy link
Contributor

commented Sep 9, 2019

  • When fetching the repo, we double check the commit presence, because it's likely that the lock we were waiting onto was already fetching that same commit.

  • clear_git_cache! can directly bail out before locking if the repo doesn't exist.

@casperisfine casperisfine requested review from wvanbergen and DazWorrall Sep 9, 2019

@DazWorrall
Copy link
Member

left a comment

Very nice 👍

@casperisfine casperisfine merged commit 33e385a into master Sep 9, 2019

3 checks passed

CLA Contributor License Agreement (CLA) status
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@shopify-shipit shopify-shipit bot deployed to rubygems Sep 9, 2019 Active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.