Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose GitHub repository info to tasks #977

Merged
merged 1 commit into from Jan 8, 2020
Merged

Conversation

@DazWorrall
Copy link
Member

DazWorrall commented Jan 8, 2020

A use case has arose for this.

@DazWorrall DazWorrall requested review from byroot and casperisfine Jan 8, 2020
Copy link
Contributor

casperisfine left a comment

LGTM, just not 100% sure about the API.

@@ -41,6 +41,8 @@ def env
'IGNORED_SAFETIES' => @task.ignored_safeties? ? '1' : '0',
'GIT_COMMITTER_NAME' => @task.user&.name || Shipit.committer_name,
'GIT_COMMITTER_EMAIL' => @task.user&.email || Shipit.committer_email,
'GITHUB_REPO_OWNER' => @stack.repository.owner,
'GITHUB_REPO_NAME' => @stack.repository.name,

This comment has been minimized.

Copy link
@casperisfine

casperisfine Jan 8, 2020

Contributor

Hum, I wonder if it should be two variables, or just one with the full name.

This comment has been minimized.

Copy link
@DazWorrall

DazWorrall Jan 8, 2020

Author Member

It's easy enough for users to compose if they choose, rather than having to figure out some bash foo to split them.

This comment has been minimized.

Copy link
@DazWorrall

DazWorrall Jan 8, 2020

Author Member

We could do both of course, and add a GITHUB_REPO_FULL_NAME or something.

@DazWorrall DazWorrall merged commit 826e578 into master Jan 8, 2020
3 checks passed
3 checks passed
CLA Contributor License Agreement (CLA) status
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@shopify-shipit shopify-shipit bot deployed to rubygems Jan 10, 2020 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.